-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcU: Ignore newHead if it is an ancestor of chain head #4055
fcU: Ignore newHead if it is an ancestor of chain head #4055
Conversation
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@@ -434,7 +440,7 @@ boolean ancestorIsValidTerminalProofOfWork(final BlockHeader blockheader) { | |||
|
|||
boolean resp = | |||
parent.filter(header -> isTerminalProofOfWorkBlock(header, protocolContext)).isPresent(); | |||
LOG.warn( | |||
LOG.debug( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed this one to debug, because it does not look like anything that should cause a warning in the log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I have misgivings about this behavior, but the hive suite seems to have made this optional behavior mandatory.
PR description
A forkchoice update will be ignored if
newHead
is an ancestor of chain head.Fixed Issue(s)
fixes #4051
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog